Skip to content

Conversation

@sean-brydon
Copy link
Member

@sean-brydon sean-brydon commented May 2, 2025

What does this PR do?

CleanShot 2025-05-02 at 08 56 01

Uses the correct component in booker instead of the routing forms widgets


Summary by mrge

Fixed the booker email input to use the correct input component instead of the routing form widget. This ensures proper handling of email values in the form.

@sean-brydon sean-brydon requested a review from hariombalhara May 2, 2025 07:58
@graphite-app graphite-app bot requested a review from a team May 2, 2025 07:58
@keithwillcode keithwillcode added consumer core area: core, team members only labels May 2, 2025
@dosubot dosubot bot added the booking-page area: booking page, public booking page, booker label May 2, 2025
if (!props) {
return <div />;
}
return <Widgets.TextWidget type="email" id={props.name} noLabel={true} {...props} />;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use input field in the rest of this components file - not sure why we used widget here.

@hariombalhara
Copy link
Member

It affects both Routing Form field and Booker field right?

@graphite-app
Copy link

graphite-app bot commented May 2, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (05/02/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (05/02/25)

1 label was added to this PR based on Keith Williams's automation.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mrge reviewed 1 file and found no issues. Review this PR in mrge.io.

@sean-brydon
Copy link
Member Author

sean-brydon commented May 2, 2025

It affects both Routing Form field and Booker field right?

Yes but the one thats rendered in the form not the form builder that uses a different set of components

cal.com/packages/app-store/routing-forms/components/react-awesome-query-builder/widgets.tsx The RAQB form builder uses these components where as the components rendered in booker/forms use the components in

cal.com/packages/features/form-builder/Components.tsx

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2025

E2E results are ready!

@vercel
Copy link

vercel bot commented May 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview May 5, 2025 8:45am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview May 5, 2025 8:45am

@Udit-takkar Udit-takkar enabled auto-merge (squash) May 5, 2025 08:44
@Udit-takkar Udit-takkar merged commit ec93848 into main May 5, 2025
37 of 38 checks passed
@Udit-takkar Udit-takkar deleted the fix/booker-rfv3-artifacts branch May 5, 2025 09:05
alishaz-polymath pushed a commit that referenced this pull request May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

booking-page area: booking page, public booking page, booker consumer core area: core, team members only ready-for-e2e

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants